Ticket #219 (closed defect: fixed)

Opened 2 months ago

Last modified 2 weeks ago

Sound_out has a problem with current SI & IDL

Reported by: mcarrick Assigned to: shereef
Priority: major Milestone:
Component: platform Version: trunk
Keywords: IDL, standardInterfaces, SI, Sound_out Cc:

Description

From what I understand, Sound_out does not implement the complexShort port like the current standardInterfaces requires.

Change History

07/23/08 16:37:48 changed by mcarrick

  • component changed from OSSIE Eclipse Feature to platform.

07/23/08 16:53:16 changed by bhilburn

By 'current standardinterfaces' you are referring to standardinterfaces-metadata, correct?

07/23/08 16:54:53 changed by mcarrick

Correct.

07/23/08 18:14:53 changed by balister

Well, maybe people should read (and understand Sound_out)

  • I wrote Sound_out several years ago. It pre-dates standard interfaces.
  • Sound_out absorbs data at a rate set by the sound hardware. If data is sent faster, it drops data.

When I updated components to use standard interfaces, the provides port code would not work in Sound_out due to the dropping data on overruns behavior.

Quite frankly, the sound support needs a complete overhaul. As with any piece of code I wrote that long ago, there are much better design decisions that could be made. (The polite thing to say is refactor) The device should support both the input and output paths from the sound hardware, and be able to support the various lower level sub-systems available, such as raw alsa and port audio.

Also, there is a design decision about handling overruns. The drop data during overruns is OK when the data is coming at close to the playback rate, but if you are reading data from a file, processing it, and the sending it to the sound hw, dropping is bad, rather the code should block until there is room for more data.

So basically, the least of the problem here is compiling this code against the meta standard interfaces code :)

07/26/08 15:46:51 changed by shereef

  • owner changed from ssayed to shereef.
  • status changed from new to assigned.

07/28/08 12:37:04 changed by mcarrick

  • milestone changed from 0.7.0 to Release 0.8.0.

09/12/08 13:49:21 changed by mcarrick

  • status changed from assigned to closed.
  • resolution set to fixed.
  • milestone changed from Release 0.8.0 to 0.7.0.

This issue has been fixed in the trunk line of development by removing SI-MD overwriting SI.

09/21/08 13:36:21 changed by

  • milestone deleted.

Milestone 0.7.0 deleted