Ticket #83 (closed defect: fixed)

Opened 6 years ago

Last modified 5 years ago

OWD crashes if it cannot find .spd.xml files associated with nodes

Reported by: jgaeddert Owned by: DrewCormier
Priority: minor Milestone:
Component: tools Version:
Keywords: Cc:

Description

If the default_GPP_USRP_node is installed but the USRP device is not, OWD will crash because it cannot find USRP.spd.xml. OWD needs to either

  1. ignore the node and throw a warning box, or
  2. handle FileIO exceptions by 'crashing' gracefully

Change History

  Changed 6 years ago by jgaeddert

You could use the python os module to check existence of the file first, viz

# ...
    if not os.path.exists(base_path + os.sep + filename):
        print "Warning! Could not find " + filename
        print "cannot import node " + nodename
        return False
#...

follow-up: ↓ 3   Changed 6 years ago by balister

What is the plan to close this bug? Does the suggested fix require further review?

in reply to: ↑ 2   Changed 6 years ago by jgaeddert

Replying to balister:

What is the plan to close this bug? Does the suggested fix require further review?

The suggested fix is more pseudocode than anything else. Someone needs to make a decision what the tool should do in such a situation and handle the error appropriately.

  Changed 6 years ago by DrewCormier

  • status changed from new to closed
  • resolution set to fixed

  Changed 5 years ago by anonymous

  • milestone 0.6.2 deleted

Milestone 0.6.2 deleted

Note: See TracTickets for help on using tickets.